Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: fixing engine backup location if not /root ...................................................................... upgrade: fixing engine backup location if not /root On upgrades, the engine backup file is always injected under /root on the appliance. Fixing if the user keeps on different location on the host. Using otopi's resolveFile to make it safe against relative paths. Making the destination path user configurable. Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34 Bug-Url: https://bugzilla.redhat.com/1394740 Bug-Url: https://bugzilla.redhat.com/1396193 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com&gt; --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py 4 files changed, 16 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Sefi Litmanovich: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Sefi Litmanovich <slitmano(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;