Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Add makeSortable() to LUN columns ...................................................................... webadmin,userportal: Add makeSortable() to LUN columns Just like in other Column classes, the no-arg makeSortable() method is a convenience so that devs don't have to provide Comparator each time they want to mark a column as sortable. Change-Id: I7206969dc9d2d056fab8ef7db69e3a5563e6c928 Bug-Url: https://bugzilla.redhat.com/1305011 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com&gt; Signed-off-by: Tal Nisan <tnisan(a)redhat.com&gt; --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLunAvailableSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLunTextColumn.java 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests Benny Zlotnik: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/70144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7206969dc9d2d056fab8ef7db69e3a5563e6c928 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;