Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveVm: no image checks for LUN based VMs
......................................................................
core: RemoveVm: no image checks for LUN based VMs
Since now ImagesHandler.PerformImagesChecks no longer handles VM-level
validations, it's possible to skip it altogether if the VM has no image
disks (i.e., no disks at all, or just LUN disks) associated with it.
Note: This refactoring is a step in a long series of patches intended to
completely remove PerformImagesChecks.
Change-Id: Ief6ebb5d3d5b23075424acc92a616f2d7e338170
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/12144
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief6ebb5d3d5b23075424acc92a616f2d7e338170
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>