Sahina Bose has submitted this change and it was merged. Change subject: engine: add feature comptability check for VDS ...................................................................... engine: add feature comptability check for VDS Some times checking for the cluster compatibility version is not enough to support some features across multiple comptability versions. So we need to have some machanism while adding a node to cluster to check that vdsm supports all the required features required for the cluster. This patch adds feature compatability check for VDS. List of all additional features will be maintained in a master table. List of features will be shown in the new/edit cluster dialog based on the compatability version selected as well as the services gluster/virt enabled. User can select the features he wants in the cluster and cluster will be initialized with that set of feature during cluster creation. When a node is added to the cluster, it checks that all the required features for the cluster are supported by vdsm. This is done in a generic way so that it can used in different features in future. Currently it is used to check whether the vdsm supports gluster37 features. gluster37 features are supported in 3.6 cluster by default. It is also supported in 3.5 cluster with this feature check. Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByClusterIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByVersionAndCategoryQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdditionalFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SupportedAdditionalClusterFeature.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterFeaturesByVersionAndCategoryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterFeatureDaoTest.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/cluster_features_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_05_1480_add_cluster_features_table.sql 39 files changed, 1,280 insertions(+), 19 deletions(-) Approvals: Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com&gt; Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org