Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fixes in HostIntefaces sub table for 3.0
......................................................................
webadmin: Fixes in HostIntefaces sub table for 3.0
https://bugzilla.redhat.com/840307
https://bugzilla.redhat.com/823920
1. Detach should show confirm detach dialog and not add network dialog.
2. Selection shouln't be changed when clicking on the row,
just when choosing a checkbox.
Because clicking on the row selected the nic, the vlan was never selected-
(even when checking the vlan checkbox) so action on vlan didn't
work.
Change-Id: Ief5016e3630f704e3069b56843182470da591f28
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TogglePanel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
4 files changed, 60 insertions(+), 62 deletions(-)
Approvals:
Alona Kaplan: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/6342
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief5016e3630f704e3069b56843182470da591f28
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>