Daniel Erez has submitted this change and it was merged. Change subject: core: validate IQN on update iSCSI connection ...................................................................... core: validate IQN on update iSCSI connection * Add a canDo validation to UpdateStorageServerConnectionCommand for empty IQN (similar to AddStorageServerConnectionCommand). * Updated unit tests accordingly. Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c Bug-Url: https://bugzilla.redhat.com/1005284 Signed-off-by: Daniel Erez <derez(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java 2 files changed, 20 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22880 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437d93f90f6199238cc7cbe9c264c5bf72cca71c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server