Omer Frenkel has submitted this change and it was merged.
Change subject: core: No ';' at the end of customProperties
......................................................................
core: No ';' at the end of customProperties
Construct customProperties value always without ';' at the end.
CustomPropertiesUtils.convertProperties() and
VmPropertiesUtils.customProperties() produced different results in this
case which caused comparisons to fail.
Change-Id: Ibcbb840537dc55c9264cec769ee0b250af409838
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1238742
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/VmPropertiesUtils.java
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/43939
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcbb840537dc55c9264cec769ee0b250af409838
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org