Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: ListModelTypeAheadListBox to not always add to valid values
......................................................................
webadmin: ListModelTypeAheadListBox to not always add to valid values
Added a parameter that determines whether the widget should
automatically add values to the list of "valid" values (those
suggested). This is particularly useful when the selected value is
initialized to some value, that shouldn't be chosen again once it's
been changed (which is the case for the vNIC widget).
Change-Id: Ic35073123696fe7e727464079c31794935a7ad70
Bug-Url:
https://bugzilla.redhat.com/1020861
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileEditor.java
3 files changed, 26 insertions(+), 4 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit
http://gerrit.ovirt.org/26753
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic35073123696fe7e727464079c31794935a7ad70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server