Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Changed arrow sign from text to image
......................................................................
webadmin: Changed arrow sign from text to image
Used to have the Unicode characters for triangles as the label of a
button, but would come out garbled in non-English locales. Now using
an image instead, with the help of ShapedButton.
Also took the chance to give HorizontalSplitTable and
ImportNetworksPopupView a tighter look with the help of a designer.
Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2
Bug-Url:
https://bugzilla.redhat.com/1000285
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_click.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_disabled.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_normal.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_down_over.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_click.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_disabled.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_normal.png
A
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/arrows/tri_up_over.png
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml
13 files changed, 60 insertions(+), 29 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/19457
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55f73d3edc261e4e16c19a7e345dbb1dc105c9b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server