Allon Mureinik has submitted this change and it was merged. Change subject: core: Use longs to represent dates in QueryData ...................................................................... core: Use longs to represent dates in QueryData Use longs representing the amount of milliseconds since the epoch instead of Data instances in order to prevent accidental change of QueryData's internal members externally. Besides being a good defensive practice, this patch solves the EI_EXPOSE_REP and EI_EXPOSE_REP2 FindBugs warnings on this class. Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eb83c123a4fd9a1b2abc3bdb74d91a1391245d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server