Change in ovirt-engine[master]: core: change order of validations in RemoveStorageDomainCommand

Tal Nisan has submitted this change and it was merged. Change subject: core: change order of validations in RemoveStorageDomainCommand ...................................................................... core: change order of validations in RemoveStorageDomainCommand Currently when attempting to remove a storage domain, part of the validation process attempts to mount a storage domain to check if it's attached to a DC and then disconnects. If the storage is already attached, disconnecting from it may trigger a master domain reconstruction (if it's the master) and it shouldn't do that. The patch moves the isStorageDomainAttached check to the end of the validation since we can fail earlier by querying the database and discovering the domain is already attached without triggering the reconstruction. Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc Bug-Url: https://bugzilla.redhat.com/1444120 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveStorageDomainCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Benny Zlotnik: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id13fa174e79441b6c0641b7b7190efe16f99fbfc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;