Change in ovirt-engine[master]: core: audit console's client ip change in vm-analyzer
Arik Hadas has submitted this change and it was merged.
Change subject: core: audit console's client ip change in vm-analyzer
......................................................................
core: audit console's client ip change in vm-analyzer
There is no reason not to audit a change in console's client ip in
VmAnalyzer. We do not call bll command so no need to put it in
VdsEventListener. We do not do anything in a batch for all VMs
reported on the same host so no need to do it in VmsMonitoring.
Thus, moving it to VmAnalyzer.
Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java
5 files changed, 10 insertions(+), 33 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>