Change in ovirt-engine[master]: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm
......................................................................
core: Cleanup AbstractDisk.isDiskCanBeAddedToVm
Extracted the updateDisksFromDb() method from isDiskCanBeAddedToVm()
method for better encapsulation, and employed the early-return idiom for
better readability.
Relates-To: https://bugzilla.redhat.com/854964
Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
3 files changed, 13 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>