Tal Nisan has submitted this change and it was merged. Change subject: core: Validation of copy Template disk should use image id ...................................................................... core: Validation of copy Template disk should use image id The validation for Cinder and LUN disks on copy operation uses the parameter value of imageGroupId to fetch the disk. If the operation is being done on a Template, the paramtere of imageGroupId is not initialized, but instead only with image id is. That is why the validation does not block the operation of copy Cinder disk in a Template. The proposed fix, fetches the disk using the image id when the image group id is empty or null (which indicates that a copy template disk was called). Change-Id: Ibc5f7c228d014a9db2dd74c4edc6d3e13a37a991 Bug-Url: https://bugzilla.redhat.com/1275056 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/47798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc5f7c228d014a9db2dd74c4edc6d3e13a37a991 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org