Change in ovirt-engine[master]: core: CommandBase - avoid releasing lock if there is a callback
Liron Aravot has submitted this change and it was merged.
Change subject: core: CommandBase - avoid releasing lock if there is a callback
......................................................................
core: CommandBase - avoid releasing lock if there is a callback
Currently command can be marked to keep it's acquired lock after the
execute phase ends. However, if it doesn't have tasks the locks will be
released regardless.
This patch changes that, if it was marked to keep the locks after the
execute phase and there is a callback, it's the callback responsibllity
to run the command endMethod() once polling has finished to release the
acquired locks.
Change-Id: If8600ee529f68a1b3e2881f4e33f44fec9402beb
Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8600ee529f68a1b3e2881f4e33f44fec9402beb
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org