Alona Kaplan has submitted this change and it was merged. Change subject: core: tests for NetworkAttachmentValidator ...................................................................... core: tests for NetworkAttachmentValidator • getNetworkValidator —> createNetworkValidator: a) changed method visibility to package local to be available for mocking (stubbing) b) removed caching of NetworkValidator for easier handling in tests + it was probably premature optmization. • notManagementNetwork —> notRemovingManagementNetwork: renamed method to be more descriptive; produced error complaints about unability to remove… not about not-being management network. Change-Id: Ia4ba4327b93f8628e234e0e2b23234d8b89902b5 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java 4 files changed, 737 insertions(+), 34 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/36570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4ba4327b93f8628e234e0e2b23234d8b89902b5 Gerrit-PatchSet: 60 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: automation@ovirt.org