Change in ovirt-engine[master]: webadmin: fix IAE on run once dialog
Omer Frenkel has submitted this change and it was merged.
Change subject: webadmin: fix IAE on run once dialog
......................................................................
webadmin: fix IAE on run once dialog
This patch fixes IllegalArgumentException that was thrown when trying to
run-once a VM with no bootable device.
Before change http://gerrit.ovirt.org/#/c/11735 the boot sequence that
was generated when trying to run-once a VM was never empty - it always
contained at least the hard-disk (even for diskless VM).
After applying the change above, the returned boot sequence for a VM
with no bootable device is empty, and wrong handling of the empty
string that represents it results in IllegalArgumentException.
Change-Id: I42197615331c6b62f5978e1d4546298aee617db4
Bug-Url: https://bugzilla.redhat.com/885994
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BootSequenceModel.java
3 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/12454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42197615331c6b62f5978e1d4546298aee617db4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>