From Juan Hernandez <juan.hernandez@redhat.com>:
Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add ticket action to vm graphics console ...................................................................... restapi: Add ticket action to vm graphics console Previously it was only possible to request console ticket at the VM level which in cases of SPICE+VNC automatically preferred SPICE thereby preventing the user from requesting a VNC ticket. Now also the per-graphics-console /vms/{vm_id}/graphicsconsoles/{console_id}/ticket action is supported when user wants to explicitly decide which console to use. The logic in BackendVmResource was moved to BackendVmGraphicsConsoleResource and the vm resource now (based on the same logic as before) delegates to the appropriate graphics console subresource. Change-Id: I5999171cf4f9d0609f258d329efd1240974aa815 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1383342 Signed-off-by: Martin Betak <mbetak@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleHelperTest.java 4 files changed, 106 insertions(+), 51 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/67174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5999171cf4f9d0609f258d329efd1240974aa815 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>