Change in ovirt-engine[master]: core: Sysprep can not handle values with dollar
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: Sysprep can not handle values with dollar
......................................................................
core: Sysprep can not handle values with dollar
The values which are replaced in SysprepHandler
can not contain a dollar '$' sign.
Fixed by changing the SysprepHandler to use StringBuilder
and to use Matcher.quoteReplacement(value)
The changed functionality is tested in
SysprepHandlerTest.java
Change-Id: I6e93afea963c3f69cbabaf413ffebb5c7a7e0b51
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
A
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java
2 files changed, 110 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e93afea963c3f69cbabaf413ffebb5c7a7e0b51
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>