Change in ovirt-engine[master]: webadmin: removed ugly if-else chain
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: removed ugly if-else chain
......................................................................
webadmin: removed ugly if-else chain
most of given 'rules' can be replaced by polymorphism.
Remaining ones(VmPool, DbUser and DbGroup) are probably only badly
created and should be fixed to remove this chain altogether.
Returning Guid.Empty is not apropriate and should be removed as well.
Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
1 file changed, 20 insertions(+), 66 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic716dc67b90c1d575de14c40b504c984bf0467f2
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server