Change in ovirt-engine[master]: restapi: Extending disk editing when adding a new template.
Liron Aravot has submitted this change and it was merged.
Change subject: restapi: Extending disk editing when adding a new template.
......................................................................
restapi: Extending disk editing when adding a new template.
Currently when adding a new template, its disks edit is enabled only
when the disk's storage domain is specified- In this case, editing
any other field is ignored by the REST, and the request which is sent
to the backend does not contain all the values the user posted.
This patch makes the REST request for a new template to consider every
given value related to the new template's disks whether the storage
domain is specified and whether it is not, so the disk values that
are provided will always be sent to backend.
The specified attributes given in the REST request will be patched on
the original disk using a mapper so that a sent disk will contain a
default value in case some of its fields will not be provided by the
user.
Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03
Bug-Url: https://bugzilla.redhat.com/1110798
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java
2 files changed, 44 insertions(+), 15 deletions(-)
Approvals:
Ori Liel: Looks good to me, approved
Amit Aviram: Verified
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/37808
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0baf4e5bd7233fbc4eab2f1f671b8b15e08ba03
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server