Change in ovirt-engine[master]: webadmin: Nic labels should be sorted
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Nic labels should be sorted
......................................................................
webadmin: Nic labels should be sorted
Nic labels should be presented according to LexoNumeric order.
There are two places that should be sorted-
1. Setup Networks- edit nic dialog- the current labels.
2. Host interface subtab- the labels tooltip (on nic or bond).
Note-
Setup Networks->edit nic dialog->suggested labels- are already
sorted. HostSetupNetworksModel.getFreeLabels() takes care of it.
Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff
Bug-Url: https://bugzilla.redhat.com/1091674
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfaceLabelWithToolTip.java
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Alona Kaplan: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28fb7750504bffdadd9d92f00565e21c272127ff
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server