From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Clarify the units of `provisioned_size`
......................................................................
Clarify the units of `provisioned_size`
This patch changes the example to add a VM disk so that it is clearer
that size of a disk has to be specified in bytes. It also changes the
example to use a more realistic size, 10 GiB, as it currently the size
is 1 MiB, which isn't realistic.
Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/examples/add_floating_disk.rb
M sdk/examples/add_vm_disk.rb
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/66070
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>