Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveImageCommand - avoid image staying LOCKED, revert to ILLEGAL ...................................................................... core: RemoveImageCommand - avoid image staying LOCKED, revert to ILLEGAL When running remove image command, a DeleteImageGroup vdsm task is being initiated by the engine. In case of failure or engine crash, the engine can't tell whether the task has been initiated on vdsm side or not - therefore the image status should be set to ILLEGAL, in the current situation the image just stayed LOCKED. NOTE: the lockImage() with no compensation was left in BaseImagesCommand as it's used by commands that are being executed within transaction, so until they will changed to be non transactive, there's no need to start new transaction within their execution. Change-Id: Ib5ec91a5f8b8495b8cfd11b19016fee5993644ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=840525 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 2 files changed, 30 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5ec91a5f8b8495b8cfd11b19016fee5993644ba Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>