Change in ovirt-engine[ovirt-engine-3.6]: core: Prevent host device copy on pinned host mismatch
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevent host device copy on pinned host mismatch
......................................................................
core: Prevent host device copy on pinned host mismatch
When user is creating a VM from pre-existing configuration
(Template/Snapshot/Import) and has the ability to override the "pinned-to-host"
value, it results in a VM being created with inconsistent host devices attached
(device name from old host, but with new host id).
Most cases were covered by VmDeviceUtils#copyVmDevices and import by
VmDeviceUtils#addImportedOtherDevices.
Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281428
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 47 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Peřina: Looks good to me, approved
Martin Betak: Verified
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/52493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>