Change in ovirt-engine[master]: webadmin, userportal: Add workaround-related info in UI code
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Add workaround-related info in UI code
......................................................................
webadmin,userportal: Add workaround-related info in UI code
This patch adds information on notable workarounds related to
3rd party code (GWT, GWT-Platform) by means of Java comments
in following format:
// TODO-GWT: description goes here
When upgrading versions of 3rd party dependencies, comments
on notable workarounds will make it easier to review existing
UI code during the version upgrade.
Change-Id: I336da10b2931825a7b44c24b663e18593f489979
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/MenuBar.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/SearchPanelView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/SystemTreeModelProvider.java
4 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Alexander Wels: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit http://gerrit.ovirt.org/24995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I336da10b2931825a7b44c24b663e18593f489979
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server