Change in ovirt-engine[master]: core: report SwitchType also on bonds
Moti Asayag has submitted this change and it was merged.
Change subject: core: report SwitchType also on bonds
......................................................................
core: report SwitchType also on bonds
• all networks get same switch type, so it need not be specified per
HostNetwork. It should be sufficient to have it specified only once in
paramaters class.
• onces that's done, we need not to update CreateOrUpdateBond class
with SwitchType just as HostNetwork used to contain it
(which would be totally incorrect(*)), and use SwitchType from
parameters class.
(*) it's problematic to share TO to pass data between more than 2 app
layers. It can work, until all its data makes sense everywhere, but
here we need only to pass switch type of CreateOrUpdateBond from bll
to vdsm. It's totally meaningless for UI and thus it must not be added
into this class.
Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
4 files changed, 35 insertions(+), 27 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65416
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5a8d2ebc70eb50a73d9c379beb0ea18e5a50ef1
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>