Tal Nisan has submitted this change and it was merged.
Change subject: Use the proper whitelist for MigrateVmCommand.canDoAction
......................................................................
Use the proper whitelist for MigrateVmCommand.canDoAction
The execute methods gets whitelist using the getVdsWhiteList
method. But canDoAction used getParameters directly.
This caused trouble for MigrateVmToServerCommand which overrides
getVdsWhitelist as a different value was used for canDoAction
and execute calls.
Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1258960
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
(cherry picked from commit 4fc4bb5ab27c8e0c69112d4c331aeaa6e4774e86)
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/53038
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>