Change in ovirt-engine[master]: core: Create random IDs in StorageConnectionValidatorTest
Tal Nisan has submitted this change and it was merged.
Change subject: core: Create random IDs in StorageConnectionValidatorTest
......................................................................
core: Create random IDs in StorageConnectionValidatorTest
The GUIDs in StorageConnectionValidatorTest were created statically from
arbitrary GUIDs, this is a bad practice as the behavior should not use
specific GUIDs as they are meaningless but rather use random generated
ones
Change-Id: I0d02c24f9dc0800149b3b0d3d58a9f1d99c92fed
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidatorTest.java
1 file changed, 9 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d02c24f9dc0800149b3b0d3d58a9f1d99c92fed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>