From Liron Aravot <laravot@redhat.com>:
Liron Aravot has submitted this change and it was merged. Change subject: core: Allow to deactivate an Inactive domain ...................................................................... core: Allow to deactivate an Inactive domain The Inactive status is used to mark a domain as in problem. We can conclude that there's a problem with a domain by inspecting the monitoring results retrieved from the data center hosts. Deactivating a domain essentially means to stop monitoring the domain, that's currently allowed what the domain is Active, but we may want to stop monitor it when there's a problem with it (and it's in Inactive status) as well. This patch removes the limitation on doing so and adds attempt to perform ovf update on the domain OVF stores, as we may still have access to the domain even if it's on Inactive status (so the OVF update may succeed). Change-Id: I92bd086020b9f90089b24c67ea1b1c3cf4149d9f Bug-Url: https://bugzilla.redhat.com/1445753 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/VdcActionUtilsTest.java 6 files changed, 40 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/71397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92bd086020b9f90089b24c67ea1b1c3cf4149d9f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>