Change in ovirt-engine[ovirt-engine-4.0]: core+webadmin: Audit log a network error while uploading disk.
Tal Nisan has submitted this change and it was merged.
Change subject: core+webadmin: Audit log a network error while uploading disk.
......................................................................
core+webadmin: Audit log a network error while uploading disk.
Currently when uploading a disk via webadmin, nothing warns the user
in case of a failure. e.g when the connectivity with
ovirt-imageio-proxy can't be established.
This scenario can happen if the proxy is down/not installed, or if
the user did not add the engine's CA as a certified authority in its
browser.
This patch adds AuditLog message to UploadImageStatusCommandParameters,
so if some error happens in the client side, it will append an
AuditLogMessge to the command, and this message will be logged and shown
to the user.
Also, handling the scenario of a network error in JS side is added in
this patch to demonstrate the new usage of the command and solve the
network error handling issue.
Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c
Bug-Url: https://bugzilla.redhat.com/1343878
Bug-Url: https://bugzilla.redhat.com/1328877
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
5 files changed, 43 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/62415
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7979ffec42dfa6b9f21ca74d4db7b393c2bff3c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>