Change in ovirt-engine[master]: core: ExtendSANStorageDomain storage type check
Tal Nisan has submitted this change and it was merged.
Change subject: core: ExtendSANStorageDomain storage type check
......................................................................
core: ExtendSANStorageDomain storage type check
ExtendSANStorageDomainCommand should only be applied on block storage
domains.
The current canDoAction() is wrong, as it theoritically[1] allows the
command to be run on POSIX, Gluster and LocalFS storage domains.
[1] Note: With the current code base this patch has no functional gain,
as this condition is checked in every flow that can potentially call
this command (both GUI and REST), but it is the correct thing to do, and
may serve to prevent future bugs if this command is ever called from a
different flow.
Change-Id: If25b65ba482a1659d5083f06dd76fa42c68e971e
Bug-Url: https://bugzilla.redhat.com/1213969
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/40496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If25b65ba482a1659d5083f06dd76fa42c68e971e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org