Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Improved UrlValidation
......................................................................
webadmin: Improved UrlValidation
Changed parameters from String[] to String... for convenience, and
changed the error message so that it accommodates any allowed scheme.
Change-Id: I1dcf6c4d6eb1e79c1086e39a7885c1ef061e3ca4
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java
M
frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidationTest.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
5 files changed, 31 insertions(+), 13 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/15648
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dcf6c4d6eb1e79c1086e39a7885c1ef061e3ca4
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server