Change in ovirt-engine[master]: webadmin: Guard against premature CommonModel nullification
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Guard against premature CommonModel nullification
......................................................................
webadmin: Guard against premature CommonModel nullification
This patch ensures that CommonModel instance gets nullified via
deferred command, only after current UiCommon-related processing
is over.
In case some SyncSearch response callback still executes after
that, "getModel() != null" condition in DataBoundTabModelProvider
should guard against potential NullPointerExceptions.
This patch also removes "CommonModel != null" assertions from
UiCommonModelResolver, since it's possible for CommonModel
reference to be null in some edge-case scenarios (i.e. SyncSearch
response callback being executed after user signs out).
Change-Id: I2bf55e75d97006d230bf503fac026722321435d0
Bug-Url: https://bugzilla.redhat.com/924670
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/UiCommonModelResolver.java
3 files changed, 20 insertions(+), 7 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bf55e75d97006d230bf503fac026722321435d0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>