Change in ovirt-engine[master]: webadmin: Fix type-casting warnings in ClusterManageNetworkP...
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Fix type-casting warnings in ClusterManageNetworkPopupView and
re-arrange it.
......................................................................
webadmin: Fix type-casting warnings in ClusterManageNetworkPopupView
and re-arrange it.
In ClusterManageNetworkPopupView class:
1. Change all generic EntityModel occurencies to a specific model
class (i.e. ClusterNetworkModel).
2. Remove all type type castings.
3. Convert anonymous classes into inner ones.
Define ClusterNetworkModel class as an extetion of EntityModel<Network>
(add Network as a type parameter).
Change-Id: If0a72f5530388d1abb6758e0d9cc9e5c8ebdb3e9
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
2 files changed, 261 insertions(+), 221 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit http://gerrit.ovirt.org/26159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0a72f5530388d1abb6758e0d9cc9e5c8ebdb3e9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server