Change in ovirt-engine[master]: core: AddDiskCommand - add option to leave disk as illegal o...
Liron Ar has submitted this change and it was merged.
Change subject: core: AddDiskCommand - add option to leave disk as illegal on failure
......................................................................
core: AddDiskCommand - add option to leave disk as illegal on failure
When adding a disk in case of failure the added disk is currently being
removed automatically by the engine which is wrong in atleast some of
the cases as we might have garbage on the storage.
As first step, this change allows to restrict the command to leave the
disk in illegal status in case of failure and not delete the disk.
Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromScratchParameters.java
4 files changed, 36 insertions(+), 3 deletions(-)
Approvals:
Liron Ar: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server