Change in ovirt-engine[master]: webadmin: [Fix] Cluster subtabs did not show up
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: [Fix] Cluster subtabs did not show up
......................................................................
webadmin: [Fix] Cluster subtabs did not show up
Regression introduced by 3067b72c2b577a6e5d3e061aef38e2e6aebef115. The problem
was that the GlusterStatus parser expected that it will always get a valid
status - but it could get an empty String which caused an exception in
GlusterStatus.valueOf("")
Fixed by retuning null from this parser in case an empty string has to be
parsed. The renderer is able to take care of the null so it is not NPE
vulnerable anymore.
Change-Id: Iad3acc2369f8583b8ba78ed0efb5d1a05755d13c
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ManageGlusterSwiftPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.java
4 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3acc2369f8583b8ba78ed0efb5d1a05755d13c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org