Change in ovirt-engine[master]: packaging: stricter FQDN validation
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: stricter FQDN validation
......................................................................
packaging: stricter FQDN validation
common_utils.getConfiguredIps now returns only Ips configured on
non loopback devices.
engine_validators.validateFQDN now tolerates that the FQDN provided
could not be resolved through a DNS but just only by /etc/hosts.
However, if the FQDN is resolved by DNS, it has also to reverse
resolve the ip address provided by the DNS.
engine-setup doesn't accept anymore a FQDN that doesn't pass the
validation, avoiding failures at later stages.
Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f
Bug-Url: https://bugzilla.redhat.com/948311
Bug-Url: https://bugzilla.redhat.com/928667
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine_validators.py
M packaging/fedora/setup/output_messages.py
4 files changed, 87 insertions(+), 46 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13933
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>