Tal Nisan has submitted this change and it was merged.
Change subject: core: Handle snapshot entity instead of snapshot id.
......................................................................
core: Handle snapshot entity instead of snapshot id.
On restore we should use the snapshot entity instead only the snapshot
id to indicate the snapshot that should be deleted don commit or undo
operations.
The reason for using the snapshot entity is to be able to get more
information about the deleted snapshot like the creation date.
Change-Id: I590b52d25bb774c886fe1e4e8741f2affbf2e9b8
Bug-Url:
https://bugzilla.redhat.com/1290427
Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java
1 file changed, 13 insertions(+), 10 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/58673
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I590b52d25bb774c886fe1e4e8741f2affbf2e9b8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>