Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Simplify VnicProfile flow in NetworkModel
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Simplify VnicProfile flow in NetworkModel
......................................................................
webadmin: Simplify VnicProfile flow in NetworkModel
The previous implementation was over-complicated, and allowed users to
perform the same actions from both the Edit Network dialog and the
Network/Profiles subtab. It is now only possible to create profiles
for a newly-created network, or create profiles for a network that
used to be a non-VM network and is turned into a VM network (which
from a profiles point of view is the same as a new network).
Change-Id: I21b632e7625e24a6ecb28e278639805990f6af41
Bug-Url: https://bugzilla.redhat.com/1031558
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
4 files changed, 36 insertions(+), 132 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21b632e7625e24a6ecb28e278639805990f6af41
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server