Change in ovirt-engine[master]: engine: host setup networks validator for unmananged networks
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: host setup networks validator for unmananged networks
......................................................................
engine: host setup networks validator for unmananged networks
Validates network changes associated with unmanaged networks
The following use cases are validated:
Lables:
- a label is added to a nic with an unmanaged network
Network attachements:
- check if a network attachement containing an unmanaged network is modified/added
Removed unmanaged network
- check network in removed unmanaged network list is not a managed network on the cluster
- check network in removed unmanaged network list is an unmanaged network on the host
Bug-Url: https://bugzilla.redhat.com/1167698
Change-Id: I266383deb6ab1e6e2457749517930c94b2d3791e
Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
A
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 454 insertions(+), 3 deletions(-)
Approvals:
Marcin Mirecki: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I266383deb6ab1e6e2457749517930c94b2d3791e
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>