Change in ovirt-engine[ovirt-engine-4.0]: webadmin: eliminate unnecessary (and complicating) events.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: eliminate unnecessary (and complicating) events.
......................................................................
webadmin: eliminate unnecessary (and complicating) events.
previous code fired serie of events — first it fired update change of
version field, but informing about update to some not real value. Then
real value was calculated and field was changed to that
value(multiple times). So
there was a) unnecessary events b) one event which was wrong.
after update only one event is generated and with correct value.
Motivation: following patch wants to update switch type field value
if value of version field is changed to version older than 4.0.
Because of that, we cannot tolerate any 'version updated to 3.6'
invalid event even if it's followed immediately with 'version updated
to 4.0' . Such event can be fired ONLY if version was actually changed
to 3.6.
Bug-Url: https://bugzilla.redhat.com/1195208
Change-Id: I20064dfa01b068c8e43472507519d782e6c98ba3
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 21 insertions(+), 16 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/60568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20064dfa01b068c8e43472507519d782e6c98ba3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>