Change in ovirt-engine[master]: Adding recursive update for foreman hostgroups
Oved Ourfali has submitted this change and it was merged.
Change subject: Adding recursive update for foreman hostgroups
......................................................................
Adding recursive update for foreman hostgroups
Since hostgroups inheritance in foreman doesn't copy fields to sons it
requires engine to search for each null value recursively.
Currently we search for Arch, Os, domain, subnet and
parameters and set them accordingly in the hostgroup record.
The patch adds also names and ids that required by the provision call. I
suspect that we will need also puppet_id field and realm_id - but
currently we don't pass them so I haven't added them as well.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223572
Change-Id: I147f5abd0c2383d2a2473073e34d7a8c7a699d13
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalHostGroup.java
3 files changed, 193 insertions(+), 15 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I147f5abd0c2383d2a2473073e34d7a8c7a699d13
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org