Tal Nisan has submitted this change and it was merged. Change subject: core: error in calculating number of available macs / trimming mac pool ranges ...................................................................... core: error in calculating number of available macs / trimming mac pool ranges mac ranges was trimmed to inapproriate size; it was trimmed so that first and last mac representation can 'fit' into int datatype, but that rendered unable to fit *count* of macs in such range into int datatype, since that count would then be max_int+1 and that'd cause overflow. Bug-Url: https://bugzilla.redhat.com/1162077 Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/Range.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/RangeTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MacAddressRangeUtilsTest.java 4 files changed, 36 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bbf719deb47c795862a03deb515283b1eae9a0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server