Change in ovirt-engine[master]: core: Fix NPE in LiveMigrateVmDisksCommand
Daniel Erez has submitted this change and it was merged.
Change subject: core: Fix NPE in LiveMigrateVmDisksCommand
......................................................................
core: Fix NPE in LiveMigrateVmDisksCommand
Commit ed336c64b281bac151cb365f84668f401f272afa
removes 'setStoragePoolId(getVm().getStoragePoolId())'
from getPermissionCheckSubjects() since it's
not needed for perms check anymore.
Hence, added it back in canDoAction to prevent NPE
on canDo validations.
Change-Id: Ic64bddc52fa5c1745c6064c8243f8c4e7921ef22
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java
2 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64bddc52fa5c1745c6064c8243f8c4e7921ef22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>