Change in ovirt-engine[master]: core: refactoring in import-vm
Arik Hadas has submitted this change and it was merged.
Change subject: core: refactoring in import-vm
......................................................................
core: refactoring in import-vm
1. Add canDoAction that contains checks that should be common to all
import-vm operations in ImportVmCommandBase. Currently it only contains
the check for valid cluster
2. Move the validation of balloon device to ImportVmCommandBase as it
should be validated on all import-vm commands
3. As a first stage, we will not support to map different disks to
different storage domains, thus imageToDestinationDomainMap will not be
set in ImportVmCommandBase
4. Move the look-up of balloon device in a given devices collection to
VmDeviceCommonUtils instead of being in the import command.
Change-Id: If8f420419b2a0b5789e0337450fc3c5576bb2d8f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
3 files changed, 56 insertions(+), 48 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/32643
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8f420419b2a0b5789e0337450fc3c5576bb2d8f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org