Arik Hadas has submitted this change and it was merged. Change subject: core: prevent floating vms in unknown status ...................................................................... core: prevent floating vms in unknown status On non-responsive treatment, update VMs to unknown status only if they run on some host. This check is done in the database level, with the protection of the database lock. This way, if the monitoring has just updated the VM to down state we will not end up with a VM with unknown status and run_on_vds = NULL. This is not the ideal solution but it seems to cover the most problematic scenario and yet simple. Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Bug-Url: https://bugzilla.redhat.com/1354494 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60522 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c205e9228a32822148332af13c89e51cc80afa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>