Arik Hadas has submitted this change and it was merged. Change subject: core: model hibernation volumes as disks in database ...................................................................... core: model hibernation volumes as disks in database Hibernation volumes were represented as comma-separated string: <storage domain>,<storage pool>,<dump disk id>,<dump image id>, <conf disk id>,<conf image id> This patch changes the memory dump and memory conf volumes to be modeled as disks in the database. We distinguish memory related disks from others by checking if the snapshots table refers to them as such that contain memory dump or memory conf. We currently filter all the memory related disks in most of the queries from the database so they are not displayed in the grid of disks for example. We expose them only in queries that must return them in order to be able to restore hibernated VM and to delete them when they are not relevant anymore. The new views are temporary! This patch is only a step towards removing the comma-separated string representation of the memory volumes and to treat them as regular disks in different flows in the system. In addition, this patch converts hibernation volumes that existed before this change to disks. Change-Id: I295bd98ead191c1eab54c471ea28a217dee52051 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M packaging/dbscripts/all_disks_sp.sql M packaging/dbscripts/create_views.sql M packaging/dbscripts/disk_images_sp.sql A packaging/dbscripts/upgrade/03_06_1930_convert_hibernation_volumes_to_disks.sql 4 files changed, 354 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/37673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295bd98ead191c1eab54c471ea28a217dee52051 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org