Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Forbid attaching a locked disk to a VM ...................................................................... core: Forbid attaching a locked disk to a VM - Forbid attaching a locked disk to a VM. - Replaced message key 'ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED' which was intended for many disks to 'ACTION_TYPE_FAILED_DISKS_ARE_LOCKED as it's more appropriate. - Added a new messge key (ACTION_TYPE_FAILED_DISK_IS_LOCKED) for single disk. - Filtered disks which are in lock state from 'GetAllAttachableDisksByPoolId' stored procedure in order to filter locked disks in webadmin when attaching an existing disk to a VM. Bug-Url: https://bugzilla.redhat.com/856137 Change-Id: I109654547b68da245a5fdc2b2188feedd45c2ca7 Signed-off-by: Asaf Shakarchi <asaf@redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_de.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_it.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_nl.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 39 insertions(+), 22 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I109654547b68da245a5fdc2b2188feedd45c2ca7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>