Change in ovirt-engine[master]: core: Preventing two Network Interfaces with same IP (#83919...
Muli Salem has submitted this change and it was merged.
Change subject: core: Preventing two Network Interfaces with same IP (#839199)
......................................................................
core: Preventing two Network Interfaces with same IP (#839199)
https://bugzilla.redhat.com/839199
This patch adds a validation to setup networks to make
sure two network interfaces on the same host do not have
the same static ip.
Signed-off-by: Muli Salem <msalem(a)redhat.com>
Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NoRepetitiveStaticIpInList.java
A
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 163 insertions(+), 2 deletions(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6695
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I879959b49c7b8160bd2c7bb66284bb40d284011a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>